fix(carousel): add shadow on hover#308
Merged
rishichawda merged 5 commits intodevelopmentfrom Jan 3, 2019
Merged
Conversation
rishichawda
added
design-update 🎨
kaushiknishchay
suggested changes
Jan 3, 2019
Contributor
kaushiknishchay
left a comment
kaushiknishchay
left a comment
There was a problem hiding this comment.
- Increase the ::before ::after width to around 9%
- Implement Pause of Carousel when user hovers on an item
Contributor
Author
|
The tests are failing because of coverage threshold. I'll update the tests now. Meanwhile @kaushiknishchay and @KRRISH96 can review the code. |
kaushiknishchay
previously approved these changes
Jan 3, 2019
KRRISH96
reviewed
Jan 3, 2019
Contributor
KRRISH96
left a comment
KRRISH96
left a comment
There was a problem hiding this comment.
The pauseOnHover seems ineffective after clicking one of next or prev buttons.
Contributor
Author
Fixed in 97f5c0f |
KRRISH96
previously approved these changes
Jan 3, 2019
KRRISH96
approved these changes
Jan 3, 2019
Contributor
Author
|
🎉 This PR is included in version 1.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status :
Ready
Description :
Add shadow to increase button visibility
Related Issues :
#287
Todos