Skip to content

Conversation

@charleslien
Copy link
Contributor

No description provided.

charleslien and others added 30 commits November 25, 2025 10:14
@charleslien
Copy link
Contributor Author

What needs to be done:

  1. Review the changes made in the "require json output for tool results" commit:
  • Namely, changed ToolResultOutput from (json | media) to {value: json, media?: media[]}
  1. Change all instances of ToolResultOutput[] to ToolResultOutput
  2. Fix all the resulting type errors

@charleslien
Copy link
Contributor Author

Note: perhaps the changing instances of ToolResultOutput[] to ToolResultOutput would be easier if you renamed the new one something different (like ToolResultContent)? then the typechecker would tell you where all the instances of ToolResultOutput are, since that variable no longer exists

@brandonkachen brandonkachen force-pushed the main branch 2 times, most recently from 2c18ea5 to 08f4c5e Compare December 5, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants