fix: preserve MCP tool params when MCP schemas are rendered as allOf#459
Merged
jahooma merged 1 commit intoCodebuffAI:mainfrom Mar 9, 2026
Merged
Conversation
Contributor
|
Nice, thanks for the fix! |
reillyse
pushed a commit
to reillyse/codebuff
that referenced
this pull request
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes MCP tool parameter rendering when the schema is valid but represented as
allOfafter Codebuff combines it with the end-step flag.What was happening:
allOfparamsSection()only checked top-levelproperties, so it incorrectly rendered the tool as having no paramsWhat changed:
allOf,anyOf,oneOf, or non-emptyrequiredas meaningfulParams: NoneHow I tested it:
Params: NonenameparameterallOfcaseFixes #450