Code standards updated to PHP 7.3#9
Conversation
composer.json
Outdated
| ], | ||
| "minimum-stability": "RC", | ||
| "require": { | ||
| "php": "^7.1 || ^8.0", |
There was a problem hiding this comment.
Thank for taking this chance: since we require mezzio:v3 we can bump this even further to match it (https://github.com/mezzio/mezzio/blob/f2643cac71621ff7dcf56091214f6cd14deaaf6c/composer.json#L33), so "php": "^7.3 || ^8.0"
There was a problem hiding this comment.
Even better :-)
I didn't do it right away because I promised to update a lot of modules, and in some cases going from PHP 5.6 to PHP 7.3 requires a lot of effort and time.
| * @throws Exception | ||
| */ | ||
| public function doRequest($request) | ||
| public function doRequest($request): Response |
There was a problem hiding this comment.
I'd love this, but it's a BC Break with little advantage over the already present DocBlock.
So please leave public and protected methods as is, and only update private ones.
There was a problem hiding this comment.
@Slamdunk I undid this specific change, since doRequest comes from here and there are no return types there yet.
Nevertheless, Adding return types is really what is motivating me to submit this PR. If you look at this thread you will understand why this BC is intentional.
The idea is to release this as a major version of the module. In the case of Mezzio it would be 3.0.0, which is also consistent with the improvements included in Codeception 5.
TavoNiievez
changed the title
3 participants
Uh oh!
There was an error while loading. Please reload this page.