Skip to content

Fix PHP warning #796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
selul merged 3 commits into from
May 25, 2021
Merged

Fix PHP warning #796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e3da439
Fix PHP 8 warning #795
girishpanchal30 Apr 26, 2021
86a7410
Fix undefined array index warning in PHP 8 #795
girishpanchal30 May 4, 2021
625e6af
Merge branch 'development' of https://github.com/Codeinwp/visualizer …
girishpanchal30 May 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions classes/Visualizer/Render/Sidebar/Google.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,15 +208,15 @@ protected function _renderGeneralSettings() {
self::_renderSelectItem(
esc_html__( 'Position', 'visualizer' ),
'legend[position]',
$this->legend['position'],
isset( $this->legend['position'] ) ? $this->legend['position'] : '',
$this->_legendPositions,
esc_html__( 'Determines where to place the legend, compared to the chart area.', 'visualizer' )
);

self::_renderSelectItem(
esc_html__( 'Alignment', 'visualizer' ),
'legend[alignment]',
$this->legend['alignment'],
isset( $this->legend['alignment'] ) ? $this->legend['alignment'] : '',
$this->_alignments,
esc_html__( 'Determines the alignment of the legend.', 'visualizer' )
);
Expand Down Expand Up @@ -393,10 +393,12 @@ protected function _renderViewSettings() {
echo '<table class="viz-section-table" cellspacing="0" cellpadding="0" border="0">';
echo '<tr>';
echo '<td class="viz-section-table-column">';
echo '<input type="text" name="chartArea[left]" class="control-text" value="', $this->chartArea['left'] || $this->chartArea['left'] === '0' ? esc_attr( $this->chartArea['left'] ) : '', '" placeholder="20%">';
$chartarea_left = isset( $this->chartArea['left'] ) ? $this->chartArea['left'] : '';
echo '<input type="text" name="chartArea[left]" class="control-text" value="', $chartarea_left || '0' === $chartarea_left ? esc_attr( $chartarea_left ) : '', '" placeholder="20%">';
echo '</td>';
echo '<td class="viz-section-table-column">';
echo '<input type="text" name="chartArea[top]" class="control-text" value="', $this->chartArea['top'] || $this->chartArea['top'] === '0' ? esc_attr( $this->chartArea['top'] ) : '', '" placeholder="20%">';
$chartarea_top = isset( $this->chartArea['top'] ) ? $this->chartArea['top'] : '';
echo '<input type="text" name="chartArea[top]" class="control-text" value="', $chartarea_top || '0' === $chartarea_top ? esc_attr( $chartarea_top ) : '', '" placeholder="20%">';
echo '</td>';
echo '</tr>';
echo '</table>';
Expand Down
2 changes: 1 addition & 1 deletion classes/Visualizer/Source.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ public static final function get_date_formats_if_exists( $series, $data ) {
*
* @return string|null
*/
private static final function determine_date_format( $value, $type ) {
private static function determine_date_format( $value, $type ) {
if ( version_compare( phpversion(), '5.3.0', '<' ) ) {
do_action( 'themeisle_log_event', Visualizer_Plugin::NAME, sprintf( 'PHP version %s not supported', phpversion() ), 'error', __FILE__, __LINE__ );
return null;
Expand Down