Skip to content

Fix security vulnerability #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vytisbulkevicius merged 1 commit into from
Jul 5, 2022
Merged

Fix security vulnerability #912

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions classes/Visualizer/Gutenberg/Block.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -750,8 +750,12 @@ public function upload_csv_data( $data ) {
return false;
}

if ( $data['url'] && ! is_wp_error( $data['url'] ) && filter_var( $data['url'], FILTER_VALIDATE_URL ) ) {
$source = new Visualizer_Source_Csv_Remote( $data['url'] );
$remote_data = false;
if ( isset( $data['url'] ) && function_exists( 'wp_http_validate_url' ) ) {
$remote_data = wp_http_validate_url( $data['url'] );
}
if ( false !== $remote_data && ! is_wp_error( $remote_data ) ) {
$source = new Visualizer_Source_Csv_Remote( $remote_data );
if ( $source->fetch() ) {
$temp = $source->getData();
if ( is_string( $temp ) && is_array( unserialize( $temp ) ) ) {
Expand Down
11 changes: 8 additions & 3 deletions classes/Visualizer/Module/Chart.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1111,10 +1111,15 @@ public function uploadData() {

$source = null;
$render = new Visualizer_Render_Page_Update();
if ( isset( $_POST['remote_data'] ) && filter_var( $_POST['remote_data'], FILTER_VALIDATE_URL ) ) {
$source = new Visualizer_Source_Csv_Remote( $_POST['remote_data'] );

$remote_data = false;
if ( isset( $_POST['remote_data'] ) && function_exists( 'wp_http_validate_url' ) ) {
$remote_data = wp_http_validate_url( $_POST['remote_data'] );
}
if ( false !== $remote_data ) {
$source = new Visualizer_Source_Csv_Remote( $remote_data );
if ( isset( $_POST['vz-import-time'] ) ) {
apply_filters( 'visualizer_pro_chart_schedule', $chart_id, $_POST['remote_data'], $_POST['vz-import-time'] );
apply_filters( 'visualizer_pro_chart_schedule', $chart_id, $remote_data, $_POST['vz-import-time'] );
}
// phpcs:ignore WordPress.PHP.StrictComparisons.LooseComparison
} elseif ( isset( $_FILES['local_data'] ) && $_FILES['local_data']['error'] == 0 ) {
Expand Down