-
-
Notifications
You must be signed in to change notification settings - Fork 2
Add prometheus stats #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
c022acd
Add prometheus stats
CoderCookE 9bc3b01
Set flag name to include prometheus
CoderCookE a738c54
don't opt into open metrics
CoderCookE c6862f3
Merge remote-tracking branch 'origin/master' into ec/stats
CoderCookE 847b0bf
Merge remote-tracking branch 'origin/master' into ec/stats
CoderCookE 31e0664
Merge remote-tracking branch 'origin/master' into ec/stats
CoderCookE bf73063
Add gauges for connections and backends
CoderCookE 124f340
Merge remote-tracking branch 'origin/master' into ec/stats
CoderCookE ec75c60
add shutdown to Message Struct
CoderCookE 50605ad
try to track shutdown connections
CoderCookE e37b7eb
better calculate ideal connections
CoderCookE 62b214e
clean up fetch method
CoderCookE af27444
this was a useless stat
CoderCookE 89ef60c
pass metrics port via flag
CoderCookE 8ae2db5
fix spec
CoderCookE File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 07146cbafc06b4f95eed8425800450ef2ba87c4f ./bin/goaround | ||
| f4a5f0d8fcb88d86492e41255eb1054e75231b81 ./bin/goaround |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WOW! This brings in a lot of dependencies!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NIT: Also, consider running
go mod tidyto clean up some of these. Ex,go-spewis still listed in this file.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this actually is the output of
go mod tidy. not sure wherego-spewis coming from.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yikes! Something else may be using it. it is pulling in
go-kitandgrpc. eithe one of those could have that as a dependency.go mod graph | grep go-spewwould tell you what's using it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
something seems to be using testify and logrus which have go-spew as dependencies