Port android test stubs to capacitor 5, and exclude them from npm package#307
Merged
reslear merged 2 commits intoCodetrixStudio:masterfrom Oct 9, 2023
Merged
Conversation
Collaborator
|
could you check? |
Contributor
Author
|
Hi @reslear, I'm not sure what you want me to check? Is it the iOS tests? I don't have mac at hand, unfortunately |
Collaborator
no, test your changes like locally or npm patch |
Contributor
Author
|
Aha, this I already did. I used |
Contributor
Author
|
👏 |
cpmsmith
pushed a commit
to fellowapp/CapacitorGoogleAuth
that referenced
this pull request
Nov 26, 2025
…kage (CodetrixStudio#307) * fixe ExampleInstrumentedTest so it compiles * dont package android tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into an issue after upgrading to capacitor 5: I could not build my project anymore, because the tests from this project (which I depend on) would not compile. A recent upgrade to androidx moved some stuff around. Furthermore, the error is in a test stub, which I of course, as a consumer, do not need.
This PR: