Skip to content

make initialize return a Promise #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reslear merged 1 commit into from
Nov 29, 2023
Merged

make initialize return a Promise #328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/definitions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ export interface GoogleAuthPlugin {
* @param options - Optional initialization options.
* @since 3.1.0
*/
initialize(options?: InitOptions): void;
initialize(options?: InitOptions): Promise<void>;

/**
* Initiates the sign-in process and returns a Promise that resolves with the user information.
Expand Down
3 changes: 2 additions & 1 deletion src/web.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export class GoogleAuthWeb extends WebPlugin implements GoogleAuthPlugin {
scopes: [],
grantOfflineAccess: false,
}
) {
): Promise<void> {
if (typeof window === 'undefined') {
return;
}
Expand All @@ -64,6 +64,7 @@ export class GoogleAuthWeb extends WebPlugin implements GoogleAuthPlugin {
});

this.addUserChangeListener();
return this.gapiLoaded;
}

platformJsLoaded() {
Expand Down