Fixed asset paths in dev on Windows#315
Conversation
| resolve: { | ||
| dedupe: ['monaco-editor', 'vscode', ...localDependencies] | ||
| } | ||
| }) |
There was a problem hiding this comment.
Why is github not able to display a proper diff on this file?
There was a problem hiding this comment.
I may have messed up the line endings. I can fix it now, give me a few minutes. I'll rebase while I'm at it.
There was a problem hiding this comment.
Did you forget to push? :)
There was a problem hiding this comment.
I think I got it squared away. Would you mind testing these changes in your build environment to ensure there are no regressions?
There was a problem hiding this comment.
It still doesn't seem to be ok 🤔
dkattan
force-pushed
the
hotfix/windows-asset-path-import-meta-resolve
branch
from
202388a to
069cafa
Compare
dkattan
force-pushed
the
hotfix/windows-asset-path-import-meta-resolve
branch
from
069cafa to
9d4b2e1
Compare
CGNonofr
left a comment
CGNonofr
left a comment
There was a problem hiding this comment.
Seems to still build properly on Linux 👍
| newCode += code.slice(i, match.index) | ||
|
|
||
| const path = match[1].slice(1, -1) | ||
| const resolved = await resolve(path, url.pathToFileURL(args.path).toString()) |
There was a problem hiding this comment.
it seems the resolve function is not async
| "ansi-colors": "^4.1.3", | ||
| "dockerode": "^4.0.2", | ||
| "express": "^4.18.2", | ||
| "import-meta-resolve": "^4.0.0", |
There was a problem hiding this comment.
it should probably be a dev dependency
|
This plugin was externalized and used in #329 |
2 participants
In my environment import.meta.url does not maintain the relative path to the extension in node_modules:
So I added NPM package import-meta-resolve and used their resolve method by replacing
with
But then I had an issue because import.meta.url starts with file://C:/ causing the pathname to be /C:/node_modules which is obviously not correct
This can be mitigated by replacing
with