Skip to content

feat: Add dynamic environment interaction system and new events #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AyakorK merged 1 commit into from
Oct 22, 2024
Merged

feat: Add dynamic environment interaction system and new events #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 64 additions & 0 deletions Assets/Prefabs/RoomSystem/Corridor/CorridorX7.prefab
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,37 @@ MonoBehaviour:
m_Name:
m_EditorClassIdentifier:
newRoomPrefab: {fileID: 6459706332820108789, guid: 35bed5d2a54129845bcff6b3abaa746b, type: 3}
--- !u!1 &1856224911784812225
GameObject:
m_ObjectHideFlags: 0
m_CorrespondingSourceObject: {fileID: 0}
m_PrefabInstance: {fileID: 0}
m_PrefabAsset: {fileID: 0}
serializedVersion: 6
m_Component:
- component: {fileID: 4510731604005238534}
m_Layer: 0
m_Name: BlacksmithSpawnPoint
m_TagString: Untagged
m_Icon: {fileID: 0}
m_NavMeshLayer: 0
m_StaticEditorFlags: 2147483647
m_IsActive: 1
--- !u!4 &4510731604005238534
Transform:
m_ObjectHideFlags: 0
m_CorrespondingSourceObject: {fileID: 0}
m_PrefabInstance: {fileID: 0}
m_PrefabAsset: {fileID: 0}
m_GameObject: {fileID: 1856224911784812225}
serializedVersion: 2
m_LocalRotation: {x: -0, y: -0, z: -0, w: 1}
m_LocalPosition: {x: -0.82, y: 4.19, z: 0}
m_LocalScale: {x: 1, y: 1, z: 1}
m_ConstrainProportionsScale: 0
m_Children: []
m_Father: {fileID: 3022020511561805294}
m_LocalEulerAnglesHint: {x: 0, y: 0, z: 0}
--- !u!1 &1874311396987187176
GameObject:
m_ObjectHideFlags: 0
Expand Down Expand Up @@ -1350,6 +1381,8 @@ Transform:
m_Children:
- {fileID: 6485059341568045904}
- {fileID: 1238582843666978988}
- {fileID: 4510731604005238534}
- {fileID: 8320606197561170021}
m_Father: {fileID: 0}
m_LocalEulerAnglesHint: {x: 0, y: 0, z: 0}
--- !u!114 &1349095506272017240
Expand Down Expand Up @@ -2198,3 +2231,34 @@ TilemapRenderer:
m_Mode: 0
m_DetectChunkCullingBounds: 0
m_MaskInteraction: 0
--- !u!1 &8946740815996525297
GameObject:
m_ObjectHideFlags: 0
m_CorrespondingSourceObject: {fileID: 0}
m_PrefabInstance: {fileID: 0}
m_PrefabAsset: {fileID: 0}
serializedVersion: 6
m_Component:
- component: {fileID: 8320606197561170021}
m_Layer: 0
m_Name: AltarSpawnPoint
m_TagString: Respawn
m_Icon: {fileID: 0}
m_NavMeshLayer: 0
m_StaticEditorFlags: 2147483647
m_IsActive: 1
--- !u!4 &8320606197561170021
Transform:
m_ObjectHideFlags: 0
m_CorrespondingSourceObject: {fileID: 0}
m_PrefabInstance: {fileID: 0}
m_PrefabAsset: {fileID: 0}
m_GameObject: {fileID: 8946740815996525297}
serializedVersion: 2
m_LocalRotation: {x: -0, y: -0, z: -0, w: 1}
m_LocalPosition: {x: 4.17, y: 6.17, z: 0}
m_LocalScale: {x: 1, y: 1, z: 1}
m_ConstrainProportionsScale: 0
m_Children: []
m_Father: {fileID: 3022020511561805294}
m_LocalEulerAnglesHint: {x: 0, y: 0, z: 0}
Comment on lines +2234 to +2264
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Oct 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Ajout du point d'apparition de l'autel approuvé, mais attention au tag.

L'ajout du GameObject AltarSpawnPoint est cohérent avec les objectifs du PR. Cependant, le tag "Respawn" ne semble pas approprié pour un autel et pourrait causer des problèmes avec la logique du jeu.

Suggestion : Changez le tag "Respawn" pour quelque chose de plus approprié, comme "EventSpawn" ou "AltarSpawn". Exemple :

-  m_TagString: Respawn
+  m_TagString: EventSpawn

Assurez-vous également que la position de l'autel est correcte dans l'éditeur Unity.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
--- !u!1 &8946740815996525297
GameObject:
m_ObjectHideFlags: 0
m_CorrespondingSourceObject: {fileID: 0}
m_PrefabInstance: {fileID: 0}
m_PrefabAsset: {fileID: 0}
serializedVersion: 6
m_Component:
- component: {fileID: 8320606197561170021}
m_Layer: 0
m_Name: AltarSpawnPoint
m_TagString: Respawn
m_Icon: {fileID: 0}
m_NavMeshLayer: 0
m_StaticEditorFlags: 2147483647
m_IsActive: 1
--- !u!4 &8320606197561170021
Transform:
m_ObjectHideFlags: 0
m_CorrespondingSourceObject: {fileID: 0}
m_PrefabInstance: {fileID: 0}
m_PrefabAsset: {fileID: 0}
m_GameObject: {fileID: 8946740815996525297}
serializedVersion: 2
m_LocalRotation: {x: -0, y: -0, z: -0, w: 1}
m_LocalPosition: {x: 4.17, y: 6.17, z: 0}
m_LocalScale: {x: 1, y: 1, z: 1}
m_ConstrainProportionsScale: 0
m_Children: []
m_Father: {fileID: 3022020511561805294}
m_LocalEulerAnglesHint: {x: 0, y: 0, z: 0}
--- !u!1 &8946740815996525297
GameObject:
m_ObjectHideFlags: 0
m_CorrespondingSourceObject: {fileID: 0}
m_PrefabInstance: {fileID: 0}
m_PrefabAsset: {fileID: 0}
serializedVersion: 6
m_Component:
- component: {fileID: 8320606197561170021}
m_Layer: 0
m_Name: AltarSpawnPoint
m_TagString: EventSpawn
m_Icon: {fileID: 0}
m_NavMeshLayer: 0
m_StaticEditorFlags: 2147483647
m_IsActive: 1
--- !u!4 &8320606197561170021
Transform:
m_ObjectHideFlags: 0
m_CorrespondingSourceObject: {fileID: 0}
m_PrefabInstance: {fileID: 0}
m_PrefabAsset: {fileID: 0}
m_GameObject: {fileID: 8946740815996525297}
serializedVersion: 2
m_LocalRotation: {x: -0, y: -0, z: -0, w: 1}
m_LocalPosition: {x: 4.17, y: 6.17, z: 0}
m_LocalScale: {x: 1, y: 1, z: 1}
m_ConstrainProportionsScale: 0
m_Children: []
m_Father: {fileID: 3022020511561805294}
m_LocalEulerAnglesHint: {x: 0, y: 0, z: 0}

8 changes: 8 additions & 0 deletions Assets/Prefabs/RoomSystem/CorridorEvent.meta
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading