Skip to content

feat: RPS #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Thomlam merged 6 commits into from
Oct 24, 2024
Merged

feat: RPS #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
40492b7
feat : add multiple option and itemscollider for RockPaperCissor
Thomlam Oct 22, 2024
ae05cfa
Merge branch 'develop' into feature/rock_paper_scissors
AyakorK Oct 22, 2024
29f61e8
feat: Link Rock Paper Scissors to backend socket
AyakorK Oct 22, 2024
a04c492
Merge branch 'develop' into feature/rock_paper_scissors
AyakorK Oct 24, 2024
c2df1b4
Merge branch 'develop' into feature/rock_paper_scissors
AyakorK Oct 24, 2024
aa889ed
feat: Link RockPaperScissors, but display missing
AyakorK Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,251 changes: 1,251 additions & 0 deletions Assets/Prefabs/RockPaperCissorGame.prefab
View file
Open in desktop

Large diffs are not rendered by default.

7 changes: 7 additions & 0 deletions Assets/Prefabs/RockPaperCissorGame.prefab.meta
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Binary file added Assets/Resources/CorridorEventsRessources/ROCKPAPERCISSOR.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
215 changes: 215 additions & 0 deletions Assets/Resources/CorridorEventsRessources/ROCKPAPERCISSOR.png.meta
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Assets/Resources/Font/pixel dead SDF.asset
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2617,7 +2617,7 @@ Material:
m_Colors:
- _ClipRect: {r: -32767, g: -32767, b: 32767, a: 32767}
- _EnvMatrixRotation: {r: 0, g: 0, b: 0, a: 0}
- _FaceColor: {r: 1, g: 1, b: 1, a: 1}
- _FaceColor: {r: 1, g: 0, b: 0, a: 1}
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Attention à l'utilisation de la couleur rouge pour cette police spécifique

La modification de la couleur en rouge pur (1,0,0) pour la police "pixel dead" semble être un cas isolé, car les autres polices du projet utilisent généralement une couleur blanche (1,1,1) pour une meilleure lisibilité. Cette police est la seule à utiliser une couleur rouge vive.

Suggestions :

  • Envisager une teinte de rouge plus douce (par exemple : r: 0.8, g: 0.2, b: 0.2)
  • Ajouter un contour clair pour améliorer la lisibilité sur fond sombre
  • Considérer l'utilisation d'une variable dans le code pour permettre un ajustement facile de la couleur
🔗 Analysis chain

Attention à l'utilisation du rouge pur dans l'interface utilisateur.

La couleur rouge pure (1,0,0) peut être trop agressive visuellement et pourrait poser des problèmes de lisibilité selon le fond utilisé.

Suggestions d'amélioration :

  • Envisager une teinte de rouge plus douce (par exemple : r: 0.8, g: 0, b: 0)
  • Vérifier les ratios de contraste pour l'accessibilité
  • Considérer rendre la couleur configurable via l'inspecteur Unity pour faciliter les ajustements
🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Vérifier l'utilisation de cette police dans les scènes
# pour s'assurer que le texte reste lisible

# Rechercher les références à cette police dans les scènes
rg -l "pixel dead SDF"

Length of output: 67

Script:

#!/bin/bash
# Search for TextMeshPro components in scene files and prefabs
rg -l "TextMeshPro" --type unity

# Search for any color settings in scene files that might affect this font
rg "_FaceColor" --type unity -C 3

Length of output: 126

Script:

#!/bin/bash
# Search for TextMeshPro components in all files
rg -l "TextMeshPro"

# Search for scene files
fd -e unity

# Search for prefab files
fd -e prefab

# Search for any color settings that might affect this font
rg "_FaceColor" -C 3

Length of output: 48404

- _GlowColor: {r: 0, g: 1, b: 0, a: 0.5}
- _MaskCoord: {r: 0, g: 0, b: 32767, a: 32767}
- _OutlineColor: {r: 0, g: 0, b: 0, a: 1}
Expand Down
Loading