feat: Adapt Waiting Room #33
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,6 +12,8 @@ public class RoomManager : MonoBehaviour | |
| private SocketIOUnity clientSocket; | ||
| public static bool isInCorridorX7 = false; | ||
|
|
||
| private bool isGameCreated = false; | ||
|
|
||
| private void Start() | ||
| { | ||
| clientSocket = SocketManager.Instance.ClientSocket; | ||
|
|
@@ -56,6 +58,12 @@ private void OnTriggerEnter2D(Collider2D other) | |
| } | ||
| if (newRoom.name.Contains("CorridorX7")) | ||
| { | ||
| if (!isGameCreated) | ||
| { | ||
| isGameCreated = true; | ||
| clientSocket.Emit("rooms:create"); | ||
| } | ||
|
|
||
|
Comment on lines
+61
to
+66
Contributor
There was a problem hiding this comment. 🛠️ Refactor suggestion Suggestions d'amélioration pour la gestion des événements socket
Voici une suggestion de refactorisation : if (newRoom.name.Contains("CorridorX7"))
{
- if (!isGameCreated)
- {
- isGameCreated = true;
- clientSocket.Emit("rooms:create");
- }
+ EmitRoomCreationEventOnce();
gameTracker.SpawnCorridorEvents();
gameTracker.NextStage();
isInCorridorX7 = true;
SocketEmitter();
}Ajoutez cette nouvelle méthode : private async void EmitRoomCreationEventOnce()
{
if (isGameCreated) return;
try
{
await clientSocket.EmitAsync("rooms:create");
isGameCreated = true;
}
catch (System.Exception e)
{
Debug.LogError($"Erreur lors de l'émission de l'événement rooms:create : {e.Message}");
}
} |
||
| gameTracker.SpawnCorridorEvents(); | ||
| gameTracker.NextStage(); | ||
| isInCorridorX7 = true; | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -80,6 +80,7 @@ public void Update() | |
|
|
||
| if (godPrefabDictionary.TryGetValue(godId, out GodInfo godInfo)) | ||
| { | ||
| Debug.Log("NTR"); | ||
|
Contributor
There was a problem hiding this comment. Améliorer la qualité des messages de débogage Les messages de débogage "NTR" ne sont pas descriptifs et n'apportent aucune information utile pour le débogage. De plus, ils risquent de polluer les logs en production. Suggestions d'amélioration : - Debug.Log("NTR");
+ Debug.Log($"Message traité pour le dieu {godId}: {messageText.Substring(0, Math.Min(messageText.Length, 50))}...");- Debug.Log("NTR");
+ Debug.Log($"Affichage du dialogue: {nextMessage.title} - {nextMessage.dialogue.Substring(0, Math.Min(nextMessage.dialogue.Length, 50))}...");Also applies to: 106-106 |
||
| EnqueueMessage(godInfo.godSprite, messageText, godInfo.godName); | ||
| } | ||
| else | ||
|
|
@@ -102,7 +103,7 @@ private IEnumerator ProcessMessageQueue() | |
| if (messageQueue.Count > 0 && !isDisplayingMessage) | ||
| { | ||
| GodMessage nextMessage = messageQueue.Dequeue(); | ||
| Debug.Log("NTR"); | ||
| DisplayDialogue(nextMessage.godSprite, nextMessage.dialogue, nextMessage.title); | ||
| isDisplayingMessage = true; | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,8 +23,6 @@ public void QuitGame() | |
|
|
||
| public async void StartRoom() | ||
| { | ||
| SceneManager.LoadScene(selectedScene); | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
Attention : Incohérence dans les couches de rendu détectée
La modification du SortingLayer de 3 à 4 pour Door.prefab n'est pas totalement cohérente avec l'ensemble des préfabriqués. Les résultats montrent une division :
Cette différence pourrait créer des problèmes de rendu avec les éléments d'événements de corridor (Forgeron, Altar). Une harmonisation complète des SortingLayers devrait être envisagée.
🔗 Analysis chain
Ajustement cohérent de la couche de rendu.
La modification du SortingLayer de 3 à 4 maintient la cohérence visuelle avec les autres préfabriqués, notamment le CorridorX7.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 309
Script:
Length of output: 1226