fix paper completeness check false warning#1049
Merged
Conversation
The warning falsely reported 4 missing rules because .get() only sees state accumulated before the current location. Rules defined after the check were invisible. Using .final() sees all rules in the document. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1049 +/- ##
=======================================
Coverage 97.94% 97.94%
=======================================
Files 979 979
Lines 100890 100890
=======================================
Hits 98816 98816
Misses 2074 2074 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
zazabap
approved these changes
Apr 14, 2026
| ] | ||
| #v(1.5em) | ||
| #text(size: 10pt, style: "italic")[arXiv:2604.xxxxx] | ||
| #text(size: 10pt, style: "italic")[#link("https://arxiv.org/abs/2604.11535")[arXiv:2604.11535]] |
| ## Citation | ||
|
|
||
| If you find this project useful in your research, please cite: | ||
|
|
zazabap
added a commit
to zazabap/problem-reductions
that referenced
this pull request
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
covered-rules.get()which only sees state before the current locationcovered-rules.final()to see all rules in the document🤖 Generated with Claude Code