Skip to content

Fix #109: Add LCS to MaximumIndependentSet reduction#173

Closed
zazabap wants to merge 7 commits intoCodingThrust:mainfrom
zazabap:issue-109-lcs-to-maximumindependentset
Closed

Fix #109: Add LCS to MaximumIndependentSet reduction#173
zazabap wants to merge 7 commits intoCodingThrust:mainfrom
zazabap:issue-109-lcs-to-maximumindependentset

Conversation

@zazabap
Copy link
Copy Markdown
Collaborator

@zazabap zazabap commented Mar 4, 2026

Summary

  • Adds implementation plan for LongestCommonSubsequence model and LCS → MaximumIndependentSet reduction rule
  • Plan covers: LCS model implementation, match-graph reduction (Apostolico & Guerra, 1987), unit tests, example program, paper documentation, and export regeneration

Closes #109

zazabap and others added 7 commits March 4, 2026 20:05
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Change complexity from 2^total_length to (total_length/num_strings)^num_strings
  reflecting the standard DP algorithm O(∏n_i)
- Assert exact LCS length (4) in three-string test instead of loose range

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Add problem-def for LongestCommonSubsequence and reduction-rule
for LCS → MaximumIndependentSet with worked example and proof.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 6, 2026

Codecov Report

❌ Patch coverage is 98.11321% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.89%. Comparing base (a88812b) to head (7eac728).
⚠️ Report is 141 commits behind head on main.

Files with missing lines Patch % Lines
.../longestcommonsubsequence_maximumindependentset.rs 95.89% 3 Missing ⚠️
.../longestcommonsubsequence_maximumindependentset.rs 96.25% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #173      +/-   ##
==========================================
+ Coverage   96.88%   96.89%   +0.01%     
==========================================
  Files         200      204       +4     
  Lines       27537    27855     +318     
==========================================
+ Hits        26680    26991     +311     
- Misses        857      864       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@isPANN
Copy link
Copy Markdown
Collaborator

isPANN commented Mar 17, 2026

On Hold: Branch is severely out of date with main (11 merge conflicts in core files including src/lib.rs, src/rules/mod.rs, docs/paper/reductions.typ). The reduction logic itself is correct and well-tested, but resolving conflicts would be more work than reimplementing from scratch on current main.

Plan: Close this PR and reimplement issue #109 fresh on current main using issue-to-pr. The LCS model already exists on main (PR #598), so only the rule + tests + paper entry need to be added.

Additionally, the DOI corrections and overhead expression fixes flagged in the issue quality check should be addressed in the reimplementation.

@isPANN isPANN closed this Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Rule] LongestCommonSubsequence to MaximumIndependentSet

2 participants