Fix batch of issues found in post-merge review#642
Merged
Conversation
…atch # Conflicts: # docs/paper/reductions.typ
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #642 +/- ##
==========================================
+ Coverage 96.83% 96.86% +0.03%
==========================================
Files 246 246
Lines 31855 32287 +432
==========================================
+ Hits 30846 31276 +430
- Misses 1009 1011 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SubsetSum<T>generic over integer type withSubsetSumElementtrait, defaultT=i64, registeredi128variant, added positive-integer validation andnew_uncheckedfor internal useSubsetSum<i128>, replaced hardn+m<=18assertion withchecked_mul/checked_addgiving helpful error suggesting larger integer type"num_vertices^num_vertices"to"factorial(num_vertices)""num_vertices^2 * 2^num_required_edges"to"2^num_vertices * num_vertices^2"(Held-Karp bound)problem-defand TravelingSalesman→QUBOreduction-rulewith worked examples; added 7 missing bib entriesadd-modelskill to requiretest_<name>_paper_exampleunit testTest plan
make checkpasses (fmt + clippy + 1850+ tests)make papercompiles without errors🤖 Generated with Claude Code