Add simple NN test#66
Open
arisanguinetti wants to merge 2 commits intoCodingTrain:masterfrom
arisanguinetti:nnTests
Open
Add simple NN test#66arisanguinetti wants to merge 2 commits intoCodingTrain:masterfrom arisanguinetti:nnTests
arisanguinetti wants to merge 2 commits intoCodingTrain:masterfrom
arisanguinetti:nnTests
Conversation
13 tasks
|
Tests of nn.js is desperatly needed but I fear that running a network for 100 iterations can quickly result in the smell of slow tests. But slow tests are better then no tests! |
xxMrPHDxx
reviewed
Jun 18, 2018
| let nn = NeuralNetwork.deserialize(defaultNN); | ||
|
|
||
| for (let i = 0; i < (training_data.length * 100); i++) { | ||
| let index = i % training_data.length; |
There was a problem hiding this comment.
You should randomize the index to train the NN better probably like :-
let index = Math.random() * training_data.length | 0;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm a noobie on testing, not even sure if what I made is correct. I've created a random NN and saved the initial status. then trained the NN 100 times and compared the output with a stored target NN. I think this was mentioned in issue #53 by @shiffman