This repository was archived by the owner on Jun 30, 2025. It is now read-only.
Merged
Conversation
Will now fail upon any individual model failing
mart-r
added a commit
that referenced
this pull request
Jun 20, 2025
* CU-8699g3ajp: Update backwards compatibility workflow. Will now fail upon any individual model failing * CU-8699g3ajp: Add method to remap module packages when loading model with dill * CU-8699g3ajp: Using fixed module/class name when deserialising with dill
alhendrickson
pushed a commit
to CogStack/cogstack-nlp
that referenced
this pull request
Jun 24, 2025
* CU-8699g3ajp: Update backwards compatibility workflow. Will now fail upon any individual model failing * CU-8699g3ajp: Add method to remap module packages when loading model with dill * CU-8699g3ajp: Using fixed module/class name when deserialising with dill
alhendrickson
pushed a commit
to CogStack/cogstack-nlp
that referenced
this pull request
Jun 24, 2025
* CU-8699g3ajp: Update backwards compatibility workflow. Will now fail upon any individual model failing * CU-8699g3ajp: Add method to remap module packages when loading model with dill * CU-8699g3ajp: Using fixed module/class name when deserialising with dill
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the compatibility issues.
The effect of the PR is 2fold:
On top of that, I also updated the backwards compatibility model pack with a better / more representative example. But that won't be readily apparent here since it's done on the S3 side.