This repository was archived by the owner on Jun 30, 2025. It is now read-only.
CU-8699hj2dx Revamp component initialisation#95
Merged
Conversation
…for manual deserialisation
mart-r
added a commit
to CogStack/cogstack-nlp
that referenced
this pull request
Jun 25, 2025
* CU-8699hj2dx: Initial changes to remove config-based init args and hardcode it (WIP) * CU-8699hj2dx: Update/fix a registration test * CU-8699hj2dx: Some minor keyword argument renaming * CU-8699hj2dx: Fix RelCAT tests (init) * CU-8699hj2dx: Update Transformers NER to work when loading models * CU-8699hj2dx: Fix DeID deserialising test * CU-8699hj2dx: Fix MeaCAT init * CU-8699hj2dx: Fix RelCAT init/load * CU-8699hj2dx: Remove unused import * CU-8699hj2dx: Add doc string regarding keyword arguments when manually deserialising * CU-8699hj2dx: Update pipeline with notes regarding keyword arguments for manual deserialisation
mart-r
added a commit
to CogStack/cogstack-nlp
that referenced
this pull request
Jun 25, 2025
* CU-8699hj2dx: Initial changes to remove config-based init args and hardcode it (WIP) * CU-8699hj2dx: Update/fix a registration test * CU-8699hj2dx: Some minor keyword argument renaming * CU-8699hj2dx: Fix RelCAT tests (init) * CU-8699hj2dx: Update Transformers NER to work when loading models * CU-8699hj2dx: Fix DeID deserialising test * CU-8699hj2dx: Fix MeaCAT init * CU-8699hj2dx: Fix RelCAT init/load * CU-8699hj2dx: Remove unused import * CU-8699hj2dx: Add doc string regarding keyword arguments when manually deserialising * CU-8699hj2dx: Update pipeline with notes regarding keyword arguments for manual deserialisation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the component initialisation was previously handled in an invonenient way
__init__methodmypycheck time)What this PR does
create_new_componentas part of theBaseComponentprotocol