Skip to content

Conversation

@blaszm
Copy link
Contributor

@blaszm blaszm commented Mar 6, 2023

As discussed via E-Mail, here is a short overview of my research (multiscale bone modeling of cancellous bone) involving the usage of the CoherentStructures package for the "Related publications" section of the documentation. Besides an explanation regarding my use of the package, I included a short introduction to the topic, some important equations and links to open access publications.

Please note that I had some trouble with the make.jl file and could not test the resulting markdown/html file locally. I still hope everything works as intended.

Please let me know your opinion, I am open for any further suggestions / improvements.

Best,
Mischa

Copy link
Member

@dkarrasch dkarrasch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well written! Thanks for your contribution. I have only two small style comments. I'll merge the PR once the docs are built and we see that everything works as expected.

@blaszm
Copy link
Contributor Author

blaszm commented Mar 13, 2023

Thank you for the kind words and the feedback! Both parts should be fixed. Please let me know when there is anything else.

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (e4a74d8) 54.67% compared to head (0ee0252) 54.67%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #97   +/-   ##
=======================================
  Coverage   54.67%   54.67%           
=======================================
  Files          17       17           
  Lines        3276     3276           
=======================================
  Hits         1791     1791           
  Misses       1485     1485           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dkarrasch
Copy link
Member

I suspect that the docs don't build because you're not a member of the org. I'll merge this and fix issues afterwards, if necessary. Thanks again!

@dkarrasch dkarrasch merged commit 90d829c into CoherentStructures:master Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants