Explicitly type view controller injection and include the presentation type with the key#13
Merged
AndrewGold merged 1 commit intomasterfrom Oct 30, 2019
Merged
Conversation
AndrewGold
requested review from
hishbase,
johnnycoinbase and
petejkim
as code owners
AndrewGold
force-pushed
the
drew/view-controller-injection
branch
from
45a55c9 to
6e02c41
Compare
hishbase
approved these changes
Oct 30, 2019
| /// View controller modal presentation style | ||
| let modalPresentationStyle: UIModalPresentationStyle | ||
|
|
||
| required public init( |
|
|
||
| /// Injection-based constructor | ||
| public required init( | ||
| public init( |
| ) { | ||
| self.scope = scope | ||
| self.parameters = parameters | ||
| self.parameters = [:] |
Contributor
There was a problem hiding this comment.
make constructor required
AndrewGold
force-pushed
the
drew/view-controller-injection
branch
from
6e02c41 to
99b21dc
Compare
adam5618
added a commit
to adam5618/CBInjection
that referenced
this pull request
Mar 28, 2021
This reverts commit b7dd7da.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.