Open
Conversation
scgbckbone
commented
Apr 24, 2026
Collaborator
Author
scgbckbone
left a comment
scgbckbone
left a comment
There was a problem hiding this comment.
redo of our COLDCARD patch on the top of new mpy. Tries to mimic https://github.com/micropython/micropython/compare/master...Coldcard:micropython:mk4-base?diff=split
doc-hex
reviewed
Apr 24, 2026
| else | ||
| { | ||
| /* Prapare EP to Receive next packet */ | ||
| /* Prepare EP to Receive next packet */ |
doc-hex
reviewed
Apr 24, 2026
| // Hook for a board to run code at start up, for example check if a | ||
| // bootloader should be entered instead of the main application. | ||
| MICROPY_BOARD_STARTUP(); | ||
| #endif |
Collaborator
There was a problem hiding this comment.
our port should just nop MICROPY_BOARD_STARTUP
doc-hex
reviewed
Apr 24, 2026
|
|
||
| // chip has some special DMA between SDMMC and system | ||
| #undef ENABLE_SDIO | ||
|
|
Collaborator
There was a problem hiding this comment.
surprised DMA code in master hasn't caught up to us yet? sure we need this still?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.