Skip to content

Comments

Bump dependencies, update pytest config for pytest 9#189

Merged
Colin-b merged 7 commits intoColin-b:developfrom
helmholtzcloud:develop
Nov 15, 2025
Merged

Bump dependencies, update pytest config for pytest 9#189
Colin-b merged 7 commits intoColin-b:developfrom
helmholtzcloud:develop

Conversation

@zweizeichen
Copy link
Contributor

@zweizeichen zweizeichen commented Nov 11, 2025

I took a stab at this not knowing much about the project structure. I updated the direct dependency to pytest 9, updated the config structure (no more .ini_options) and bumped pytest-asyncio to a version that allows pytest 9 as a transitive dependency.
If we're lucky, skipping multiple versions of pytest-asyncio should not break too many things, at least I remember that from another project, but we also did a few fun things with event loops.

  • Bump pytest to 9.0
  • Adapt config to pytest 9.0
  • Update pytest-asyncio to current release
  • Drop support for Python 3.9 (EOL)
  • Add Python 3.14 to testing matrix

@olivierdolle
Copy link

olivierdolle commented Nov 13, 2025

I think you need to drop support for python 3.9 as it is not supported by pytest 9

@zweizeichen
Copy link
Contributor Author

@Colin-b what do you think? While we're at it, should I add 3.14 to the testing matrix, too?

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarQube Cloud

@zweizeichen
Copy link
Contributor Author

zweizeichen commented Nov 14, 2025

@Colin-b update: I tested a few things:

  • Bumping pytest-cov did not really work. I guess that is because you're running pytest in subprocess mode and the latest changelog mentions a few changes there. It caused lots of tests to fail, even after I added the plugin config to the pyproject.toml. But maybe it was just my setup. nevertheless I removed that change from this MR to keep the scope from exploding too much.
  • I also bumped the github actions versions for the workflows. Maybe consider enabling dependabot in the future. This can help keep this up-to-date, so far everything seems to work fine.
  • I also enabled Python 3.14 in the workflow matrix and it looks like it works as expected

There's just one issue left: apparently either coverage is reported (or has been reported until now) incorrectly and one line seems to not be covered by the test suite. Please review the log output. I can give this another look if you want but I suspect it's something you can figure out within seconds while it would take me some time to familiarize myself with the test suite, your call. I hope this helps.

Cheers!

@Colin-b
Copy link
Owner

Colin-b commented Nov 15, 2025

Thanks a lot, yeah this part is my fault actually. It is part of a new feature that still needs more testing, I should have merged the proposal in a dedicated branch instead of develop.

@Colin-b Colin-b merged commit 92394a7 into Colin-b:develop Nov 15, 2025
1 of 7 checks passed
@zweizeichen
Copy link
Contributor Author

No worries man, thank you for building and maintaining this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants