Switch to String constants#2830
Merged
REJack merged 3 commits intoColorlibHQ:masterfrom Jun 13, 2020
XhmikosR:js-string-constants
Merged
Switch to String constants#2830REJack merged 3 commits intoColorlibHQ:masterfrom XhmikosR:js-string-constants
REJack merged 3 commits intoColorlibHQ:masterfrom
XhmikosR:js-string-constants
Conversation
Should result in better compression (aprox. -10% from the compressed adminlte.min.js) and should be easier to see unused/undefined variables on lint stage.
REJack
approved these changes
Jun 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should result in better compression (aprox. -10% from the compressed adminlte.min.js) and should be easier to see unused/undefined variables on lint stage.
Draft because
readyusage there)@REJack please check the TODO and let me know how to proceed in each case.
Fixes #2704