N°8919 - 🐛 Allow creating tokens with CRON scope#6
Open
tomrss wants to merge 2 commits intoCombodo:masterfrom
Open
N°8919 - 🐛 Allow creating tokens with CRON scope#6tomrss wants to merge 2 commits intoCombodo:masterfrom
tomrss wants to merge 2 commits intoCombodo:masterfrom
Conversation
github-project-automation
bot
moved this to First review needed
in Combodo PRs dashboard
Hipska
reviewed
Apr 2, 2025
| 'Class:PersonalToken/Attribute:scope/Value:Synchro' => 'Synchro~~', | ||
| 'Class:PersonalToken/Attribute:scope/Value:Synchro+' => '/synchro/synchro_import.php and /synchro/synchro_exec.php~~', | ||
| 'Class:PersonalToken/Attribute:scope/Value:CRON' => 'CRON~~', | ||
| 'Class:PersonalToken/Attribute:scope/Value:CRON+' => '/webservices/cron.php~~', |
Collaborator
There was a problem hiding this comment.
I think you can safely remove the ~~ from all the CRON+ dicts, as the path doesn't have translations 😉
Suggested change
| 'Class:PersonalToken/Attribute:scope/Value:CRON+' => '/webservices/cron.php~~', | |
| 'Class:PersonalToken/Attribute:scope/Value:CRON+' => '/webservices/cron.php', |
Author
There was a problem hiding this comment.
Thanks for the feedback @Hipska , I updated the translations
odain-cbd
approved these changes
Apr 2, 2025
Contributor
odain-cbd
left a comment
odain-cbd
left a comment
There was a problem hiding this comment.
nice! next step is to be able to trigger cron by http asynchronously. this is another story...
jf-cbd
moved this from First review needed
to Pending functional review
in Combodo PRs dashboard
jf-cbd
moved this from Pending functional review
to Pending technical review
in Combodo PRs dashboard
jf-cbd
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base information
Symptom (bug) / Objective (enhancement)
Unable to create a token (personal or application) with
CRONscope needed to run/webservices/cron.php; theCRONoption is missing in the UI.This means that background tasks at
/webservices/cron.phpcannot be launched with token authentication.Reproduction procedure (bug)
CRONscope is not listed/webservices/cron.phpCause (bug)
Option simply missing from UI, but the
CRONscope is handled in the code.Proposed solution (bug and enhancement)
Add option to UI in order to be able to add
CRONscope to token.This PR adds the new value for the scope in the datamodel.
Other file modified are simply dictionary entries related.
Checklist before requesting a review
Checklist of things to do before PR is ready to merge
This PR contains also dictionary entries (made in the same way as previous ones) for the new
CRONtoken scope.