Skip to content

fix(addKeybind): handle MOUSE_WHEEL as a momentary trigger #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spyisgod wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(addKeybind): handle MOUSE_WHEEL as a momentary trigger #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions imports/addKeybind/client.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,11 @@ function lib.addKeybind(data)
if data.disabled or IsPauseMenuActive() then return end
data.isPressed = true
if data.onPressed then data:onPressed() end

if data.defaultMapper == 'MOUSE_WHEEL' then
data.isPressed = false
if data.onReleased then data:onReleased() end
end
end)

RegisterCommand('-' .. data.name, function()
Expand Down
5 changes: 5 additions & 0 deletions package/client/resource/addKeybind/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,11 @@ export function addKeybind(data: KeybindProps): CKeybind {
if (kb.disabled || IsPauseMenuActive()) return;
kb.isPressed = true;
kb.onPressed?.call(kb);

if (kb.defaultMapper === "MOUSE_WHEEL") {
kb.isPressed = false;
kb.onReleased?.call(kb);
}
}, false);

RegisterCommand("-" + kb.name, () => {
Expand Down