Suggestion to insert SPDX Identifier for Community Specification License#16
Merged
mkdolan merged 3 commits intodevelopmentfrom Aug 25, 2022
Merged
Suggestion to insert SPDX Identifier for Community Specification License#16mkdolan merged 3 commits intodevelopmentfrom
mkdolan merged 3 commits intodevelopmentfrom
Conversation
As suggested in Issue #6 This PR introduces the SPDX Identifier in the README file as well as a statement that can be inserted in documents to represent this license graphically.
swinslow
reviewed
Aug 19, 2022
Readme.md
Outdated
|
|
||
| The SPDX Identifier for the Community Specification V1.0 is, [`Community-Spec-1.0`](https://spdx.org/licenses/Community-Spec-1.0.html). | ||
|
|
||
| The statement to insert on files to represent this license is: |
There was a problem hiding this comment.
I would revise this to say something like "A badge indicating the Community Spec v1.0 license can be added to a MarkDown file with the following text:
Readme.md
Outdated
|
|
||
| The statement to insert on files to represent this license is: | ||
|
|
||
|  |
There was a problem hiding this comment.
A few things here:
- This probably needs to be enclosed in backticks, otherwise the image renders instead of being kept as plaintext
- Was the "APM license" alt-text inadvertently added? I don't think the APM reference applies here...
- I'd probably specifically structure the badge URL to display the correct SPDX identifier
So I think this line would probably instead get the following (with backticks surrounding it for the markdown, and note the double hyphens in the URL):
mkdolan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested in Issue #6
This PR introduces the SPDX Identifier in the README file as well as a statement that can be inserted in documents to represent this license graphically.
@swinslow comment