Remove stray "." argument passed to cargo run in RustAppHostingExtension.cs#1016
Merged
Remove stray "." argument passed to cargo run in RustAppHostingExtension.cs#1016
Conversation
Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Remove stray '.' argument from cargo run in RustAppHostingExtension.cs
Remove stray "." argument passed to cargo run in RustAppHostingExtension.cs
Nov 30, 2025
aaronpowell
approved these changes
Nov 30, 2025
Contributor
Minimum allowed line rate is |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the Rust integration was passing an invalid "." argument to cargo run, causing the command to fail. The fix removes the unnecessary argument, allowing cargo to correctly use the working directory.
- Removes the stray "." argument from the
cargo runcommand inRustAppHostingExtension.cs - Updates test assertions in
AddRustAppTests.csto verify the corrected command arguments
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/CommunityToolkit.Aspire.Hosting.Rust/RustAppHostingExtension.cs |
Removed the invalid "." argument from both conditional branches of the args array construction |
tests/CommunityToolkit.Aspire.Hosting.Rust.Tests/AddRustAppTests.cs |
Updated test assertions to expect only "run" argument (without ".") in both test methods |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Member
|
It's very odd how this test passed in |
Member
|
Manually tested and |
Alirexaa
approved these changes
Dec 1, 2025
This was referenced Jan 14, 2026
Bump CommunityToolkit.Aspire.Hosting.Flagd from 13.0.0 to 13.1.0
askpt/openfeature-aspire-sample#270
Closed
Closed
This was referenced Jan 16, 2026
This was referenced Feb 8, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1011
cargo rundoes not accept "." as a positional argument (unlikego run .). The current code producescargo run .which fails.Changes
RustAppHostingExtension.csAddRustAppTests.csto expect correct argsBefore:
cargo run . [--args]After:
cargo run [--args]PR Checklist
Other information
Cargo uses the working directory (already set correctly) to find
Cargo.toml. If a different manifest location is needed,--manifest-pathshould be used instead.Original prompt
cargo runin RustAppHostingExtension.cs #1011💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.