Fix virtualUsers conversion to string in K6BuilderExtensions#1055
Merged
aaronpowell merged 2 commits intoCommunityToolkit:mainfrom Dec 11, 2025
Merged
Fix virtualUsers conversion to string in K6BuilderExtensions#1055aaronpowell merged 2 commits intoCommunityToolkit:mainfrom
aaronpowell merged 2 commits intoCommunityToolkit:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the K6 integration where the virtualUsers parameter (an int) was being passed directly to WithArgs() instead of being converted to a string. According to Aspire's requirements, all primitive values must be explicitly converted to strings since the core framework doesn't handle formatting of primitives.
Key Changes
- Converted
virtualUsersparameter to string usingToString(CultureInfo.InvariantCulture)for culture-independent formatting
aaronpowell
approved these changes
Dec 11, 2025
This was referenced Jan 14, 2026
Bump CommunityToolkit.Aspire.Hosting.Flagd from 13.0.0 to 13.1.0
askpt/openfeature-aspire-sample#270
Closed
Closed
This was referenced Feb 8, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aspire Args that are primitive values must be strings. The Core Aspire doesn't know how to format primitive values - ex. should a
boolbeFalse,false, orFALSE?Closes dotnet/aspire#13423
PR Checklist
Other information