Conversation
There was a problem hiding this comment.
Pull request overview
This PR upgrades the Aspire Community Toolkit from version 13.1.0 to 13.2.0-preview.1.26115.1, updating SDK references, package dependencies, and NuGet configuration to support the new preview release.
Changes:
- Upgraded Aspire.AppHost.Sdk from 13.1.0 to 13.2.0-preview.1.26115.1 across 60+ example and test AppHost projects
- Updated core Aspire package versions and related dependencies (ModelContextProtocol, DotNetExtensions)
- Enabled dotnet9 package source in nuget.config for preview package access
Reviewed changes
Copilot reviewed 54 out of 54 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| Directory.Build.props | Updated AspireVersion to 13.2.0-preview.1.26115.1, cleared AspirePreviewSuffix, and updated DotNetExtensionsVersion to 10.0.2 |
| Directory.Packages.props | Updated package versions including ModelContextProtocol (0.4.0-preview.3), pinned Elasticsearch to 13.1.0 and Logging.Abstractions to 9.0.10 |
| nuget.config | Enabled dotnet9 package source for Aspire preview packages |
| CommunityToolkit.Aspire.slnx | Removed Type="Classic C#" attributes and added Solution Items folder with config files |
| .github/agents/hosting-integration-creator.agent.md | Standardized list formatting and updated example SDK version reference |
| tests/CommunityToolkit.Aspire.Testing/*.csproj | Updated to Aspire.AppHost.Sdk 13.2.0-preview.1.26115.1 |
| tests-app-hosts/Ollama.AppHost/*.csproj | Updated to Aspire.AppHost.Sdk 13.2.0-preview.1.26115.1 |
| examples/*/**.AppHost.csproj (59 files) | Updated to Aspire.AppHost.Sdk 13.2.0-preview.1.26115.1, except Python example which uses inconsistent version |
|
|
||
| ```xml | ||
| <Project Sdk="Aspire.AppHost.Sdk/13.1.0"> | ||
| <Project Sdk="Aspire.AppHost.Sdk/13.2.0-preview.1.26110.16"> |
There was a problem hiding this comment.
This example code in the documentation uses an inconsistent Aspire SDK version (13.2.0-preview.1.26110.16) compared to the version specified in Directory.Build.props (13.2.0-preview.1.26115.1). The documentation should reflect the actual version being used throughout the project to avoid confusion for developers creating new integrations.
| <Project Sdk="Aspire.AppHost.Sdk/13.2.0-preview.1.26110.16"> | |
| <Project Sdk="Aspire.AppHost.Sdk/13.2.0-preview.1.26115.1"> |
| <PackageVersion Include="Aspire.Hosting.Azure.AppContainers" Version="$(AspireVersion)" /> | ||
| <PackageVersion Include="Aspire.Hosting.Azure.Redis" Version="$(AspireVersion)" /> | ||
| <PackageVersion Include="Aspire.Hosting.Elasticsearch" Version="$(AspireVersion)" /> | ||
| <PackageVersion Include="Aspire.Hosting.Elasticsearch" Version="13.1.0" /> |
There was a problem hiding this comment.
The Aspire.Hosting.Elasticsearch package is pinned to version 13.1.0 while all other Aspire packages are upgraded to 13.2.0-preview.1.26115.1. This creates a version mismatch that could lead to compatibility issues. Either this package needs to be upgraded to match the rest of the Aspire packages, or if version 13.2.0 doesn't exist for this package yet, this should be documented with a comment explaining why it's pinned.
| <PackageVersion Include="Aspire.Hosting.Elasticsearch" Version="13.1.0" /> | |
| <PackageVersion Include="Aspire.Hosting.Elasticsearch" Version="$(AspireVersion)" /> |
| <PackageVersion Include="Microsoft.Extensions.Http" Version="$(DotNetExtensionsVersion)" /> | ||
| <PackageVersion Include="Microsoft.Extensions.Hosting.Abstractions" Version="$(DotNetExtensionsVersion)" /> | ||
| <PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="$(DotNetExtensionsVersion)" /> | ||
| <PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="9.0.10" /> |
There was a problem hiding this comment.
Microsoft.Extensions.Logging.Abstractions is pinned to version 9.0.10 instead of using the DotNetExtensionsVersion variable (10.0.2) like other Microsoft.Extensions packages. This version mismatch could cause dependency conflicts. If there's a specific reason for this pinning (e.g., compatibility constraints), it should be documented with an inline comment. Otherwise, this should use the DotNetExtensionsVersion variable for consistency.
| <PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="9.0.10" /> | |
| <PackageVersion Include="Microsoft.Extensions.Logging.Abstractions" Version="$(DotNetExtensionsVersion)" /> |
| @@ -1,4 +1,4 @@ | |||
| <Project Sdk="Aspire.AppHost.Sdk/13.1.0"> | |||
| <Project Sdk="Aspire.AppHost.Sdk/13.2.0-preview.1.26110.16"> | |||
There was a problem hiding this comment.
This file uses Aspire.AppHost.Sdk version 13.2.0-preview.1.26110.16, which is inconsistent with all other AppHost projects that use 13.2.0-preview.1.26115.1. This version mismatch could cause inconsistent behavior across the solution. All AppHost SDK references should use the same version.
Closes #1126
Preparing for the aspire 13.2 release.
PR Checklist
Other information