feat(dapr): add WaitFor support for Dapr sidecar resources#809
Closed
gabynevada wants to merge 1 commit intoCommunityToolkit:mainfrom
Closed
feat(dapr): add WaitFor support for Dapr sidecar resources#809gabynevada wants to merge 1 commit intoCommunityToolkit:mainfrom
gabynevada wants to merge 1 commit intoCommunityToolkit:mainfrom
Conversation
Implements IResourceWithWaitSupport for IDaprSidecarResource to enable proper service startup sequencing. This allows Dapr sidecars to wait for dependent services (like Redis for pubsub) to be ready before starting, preventing component loading failures during application startup. Fixes CommunityToolkit#604 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
gabynevada
requested review from
FullStackChef,
WhitWaldo and
paule96
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements WaitFor support for Dapr sidecar resources to enable proper service startup sequencing. The change addresses an issue where Dapr sidecars would start immediately while their dependencies (like Redis for pubsub) were still starting, causing component loading failures.
- Adds
IResourceWithWaitSupportinterface toIDaprSidecarResource - Includes comprehensive test coverage to verify WaitFor functionality works correctly
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Shared/Dapr/Core/IDaprSidecarResource.cs | Extends interface to implement IResourceWithWaitSupport for dependency management |
| tests/CommunityToolkit.Aspire.Hosting.Dapr.Tests/WithDaprSidecarTests.cs | Adds test case to verify WaitFor functionality implementation |
FullStackChef
approved these changes
Aug 26, 2025
Contributor
Author
|
Closing in favor of #810 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IResourceWithWaitSupportinterface forIDaprSidecarResourceDescription
This PR addresses the issue where Dapr sidecars start immediately while dependent services (like Redis for pubsub) are still starting, causing component loading failures.
By implementing
IResourceWithWaitSupport, Dapr sidecars can now properly wait for their dependencies to be ready before starting, ensuring reliable application startup.Changes
IDaprSidecarResourceto implementIResourceWithWaitSupportTest Plan
DaprSidecarSupportsWaitFor()to verify the implementationFixes #604