Adding more test coverage and fixing URL handling#825
Merged
aaronpowell merged 2 commits intomainfrom Sep 1, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds test coverage for the MCP Inspector integration and fixes URL path handling for server configurations. The changes address URL construction issues where path segments containing slashes were being incorrectly encoded.
- Adds test coverage for resource relationship annotations between MCP Inspector and server resources
- Adds test for custom path segment preservation in MCP server configuration
- Fixes URL combination logic to properly handle multi-segment paths without encoding internal slashes
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/CommunityToolkit.Aspire.Hosting.McpInspector.Tests/McpInspectorResourceBuilderExtensionsTests.cs | Adds three new test methods covering resource relationships, path preservation, and URL combination logic |
| src/CommunityToolkit.Aspire.Hosting.McpInspector/McpInspectorResourceBuilderExtensions.cs | Adds resource relationship annotation and fixes URL path combination to handle multi-segment paths correctly |
...unityToolkit.Aspire.Hosting.McpInspector.Tests/McpInspectorResourceBuilderExtensionsTests.cs
Outdated
Show resolved
Hide resolved
...unityToolkit.Aspire.Hosting.McpInspector.Tests/McpInspectorResourceBuilderExtensionsTests.cs
Show resolved
Hide resolved
Contributor
Minimum allowed line rate is |
This was referenced Sep 26, 2025
Bump CommunityToolkit.Aspire.Hosting.Sqlite from 9.7.2 to 9.8.0
askpt/openfeature-dotnet-workshop#31
Closed
This was referenced Oct 7, 2025
This was referenced Dec 8, 2025
This was referenced Jan 5, 2026
Closed
Closed
This was referenced Jan 19, 2026
This was referenced Feb 8, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #822