Updated remote object storage helpers with new WCT interfaces #131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #86
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently the roaming settings work is located in the UWP directory, making it only usable in UWP apps. It is also based on the older ObjectStorage interfaces in WCT, which are being deprecated in the near future.
What is the new behavior?
The roaming settings helpers have been majorly refactored and most importantly simplified! The new code is much easier to work with in my opinion, but it is also segmented a little differently.
Old, removed ❌
CommunityToolkit.Graph.Uwppackage:Helpers/RoamingSettings/BaseRoamingSettingsDataStore.csHelpers/RoamingSettings/IRoamingSettingsDataStore.csHelpers/RoamingSettings/OneDriveDataStore.csHelpers/RoamingSettings/RoamingSettingsHelper.csHelpers/RoamingSettings/UserExtensionDataStore.csNew, improved ✨
CommunityToolkit.Graphpackage:Helpers/RoamingSettings/IRemoteSettingsStorageHelper.cs- Defines basic sync functionality for a remote settings storage location. Based on the WCT preview interface,ISettingsStorageHelper.Helpers/RoamingSettings/OneDriveDataSource.cs- Internal class for handling Graph operations with OneDrive.Helpers/RoamingSettings/OneDriveStorageHelper.cs- Helper for storing files in OneDrive via Graph. Based on the WCT previewIFileStorageHelperinterface.Helpers/RoamingSettings/UserExtensionDataSource.cs- Internal class for handling Graph operations with user extensions.Helpers/RoamingSettings/UserExtensionStorageHelper.cs- Helper for storing settings metadata in open extensions on the Graph User object. Based onIRemoteSettingsStorageHelper.PR Checklist
Please check if your PR fulfills the following requirements:
TODO:
Microsoft.Toolkitnuget dependency once new WCT storage helper interfaces are released.