Skip to content

Conversation

@michael-hawker
Copy link
Member

  • Re-integrates PersonView from initial prototype with Provider system aligning better to Microsoft Graph Toolkit
  • UWP XAML Provider Wrappers
  • Supports Login/Logout
  • Quick Sample Test app

@michael-hawker
Copy link
Member Author

@azchohfi or @onovotny any ideas what this error is about? I thought we switched to strong naming? Or could this be some weird conflict of mismatching NuGet and MyGet feeds?

2>CSC : error CS8002: Referenced assembly 'Microsoft.Toolkit.Uwp.UI, Version=5.1.0.0, Culture=neutral, PublicKeyToken=null' does not have a strong name. [D:\a\1\s\Microsoft.Toolkit.Graph.Controls\Microsoft.Toolkit.Graph.Controls.csproj]

@clairernovotny
Copy link
Member

clairernovotny commented Sep 14, 2019

We only signed the netstandard and NET Framework targets. We didn’t strong name UWP as it ignores strong names. There may have been another reason that I can’t currently recall.

@michael-hawker
Copy link
Member Author

Thanks for the background @onovotny, I'm wondering why it's complaining then. Very odd. I'll try switching to the MyGet feed for the control package too and see if that makes any difference. I'll need to do that later anyway once Shane's PR goes in on the other repo.

@michael-hawker
Copy link
Member Author

Hey @onovotny,

I tried switching the Microsoft.Toolkit.Uwp.UI reference to the MyGet version instead of the NuGet one, that got rid of the strong name issue, but then locally is giving me this:

       "C:\code\Graph-Controls\Windows-Toolkit-Graph-Controls.sln" (Build target) (1) ->
       "C:\code\Graph-Controls\Microsoft.Toolkit.Graph.Controls\Microsoft.Toolkit.Graph.Controls.csproj" (default targe
       t) (2) ->
       (_ShowMissingLanguageTargetsError target) ->
         C:\Users\mhawker\.nuget\packages\msbuild.sdk.extras\2.0.43\Build\LanguageTargets\CheckMissing.targets(37,5): e
       rror : The specified language targets for uap10.0.16299 is missing. Ensure correct tooling is installed for 'uap
       '. Missing: 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Enterprise\MSBuild\Microsoft\WindowsXaml\v16.0\
       Microsoft.Windows.UI.Xaml.CSharp.targets' [C:\code\Graph-Controls\Microsoft.Toolkit.Graph.Controls\Microsoft.Too
       lkit.Graph.Controls.csproj]

I have the 16299 SDK installed. Have you seen this type of error before?

@michael-hawker
Copy link
Member Author

Suffice it to say, there were a couple of quirks, but the SampleApp was trying to build in the pipeline as well on the native chain and failing (which is something we don't do in the main repo). Had to remove that. Need to try adding a few things back in, like ARM, and see if that works. Will try that in the morning.

Not sure if I should jump back in the commit chain and forward-fix from there for clean-up?

@michael-hawker
Copy link
Member Author

Cleaned up and Merged as #4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants