Update to 7.0.0-preview2. #58
Conversation
…es in general, and now using the DispatcherQueue.
|
Thanks azchohfi for opening a Pull Request! The reviewers will test the PR and highlight if there is any merge conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
assigned
|
|
||
| <PropertyGroup Condition="'$(TargetFramework)' == 'uap10.0.16299'"> | ||
| <DefineConstants Condition="'$(DisableImplicitFrameworkDefines)' != 'true'">$(DefineConstants);WINRT</DefineConstants> | ||
| </PropertyGroup> |
There was a problem hiding this comment.
@azchohfi I meant to ask, I did notice that we multi-target here, but pretty sure we're just .NET Standard right, so do you remember why we might have done this?
There was a problem hiding this comment.
That is a great question... Git blame didn't help much:
526138d#diff-30f6d4fe840f95e89a9fae72c74c5362
There is a failing build on PR #4, that got fixed by this commit, but the build itself is too old, and we purged the logs.
There was a problem hiding this comment.
I wonder if I made it to help with Uno or something. We can follow-up with @jeromelaban later after UnoConf maybe?
2 participants
Updated Main toolkit dependency to 7.0.0-preview2, updated dependencies in general, and now using the DispatcherQueue.
Fixes #57
PR Type
What kind of change does this PR introduce?
PR Checklist
Please check if your PR fulfills the following requirements: