Fix NuGet pack

[michael-hawker]

Describe the bug

Related to #77

If you right-click on a library and try and Pack to build a NuGet package you get an error about Icon.png missing.

In face these resources for the icon don't exist in the repro:

https://github.com/CommunityToolkit/Labs-Windows/blob/c322845be3b1692fae6665480e9ed18ce6e4787a/Windows.Toolkit.Common.props#L12-L13

https://github.com/CommunityToolkit/Labs-Windows/blob/ed6bd23523770f34ebf6b41304dd257374fe1f04/Directory.Build.targets#L14-L19

We should be able to pack locally as well as have the proper files and icons included in the NuGet package.

@niels9001 do you know which icon asset should we use?

Steps to reproduce

1) Open an experiment or the all solution
2) Find a Library project
3) right-click on it and select 'Pack'
4) see error

Expected behavior

Able to pack NuGet package

Screenshots

No response

Code Platform

• UWP
• WinAppSDK / WinUI 3
• Web Assembly (WASM)
• Android
• iOS
• MacOS
• Linux / GTK

Windows Build Number

• Windows 10 1809 (Build 17763)
• Windows 10 1903 (Build 18362)
• Windows 10 1909 (Build 18363)
• Windows 10 2004 (Build 19041)
• Windows 10 20H2 (Build 19042)
• Windows 10 21H1 (Build 19043)
• Windows 11 21H2 (Build 22000)
• Other (specify)

Other Windows Build number

No response

App minimum and target SDK version

• Windows 10, version 1809 (Build 17763)
• Windows 10, version 1903 (Build 18362)
• Windows 10, version 1909 (Build 18363)
• Windows 10, version 2004 (Build 19041)
• Other (specify)

Other SDK version

No response

Visual Studio Version

No response

Visual Studio Build Number

No response

Device form factor

No response

Additional context

I guess this is ignored on the commandline?

Help us help you

Yes, but only if others can assist.

[michael-hawker]

Note: If you comment out the Icon.png line 12 of the Windows.Toolkit.Common.props, then you can pack locally.

[Nirmal4G]

Just stumbled across this when going through repo...

1. Remove <PackageIconUrl> as it's no longer needed. It is replaced by <PackageIcon>.
2. Place the Icon.png in the RepositoryDirectory or $(BuildToolsDirectory).
3. Then update the line...

   <None Include="$(RepositoryDirectory)nuget.png" Pack="true" PackagePath="\Icon.png" />

   TO

   <None Include="$(RepositoryDirectory)Icon.png" Pack="true" PackagePath="\" />

   OR

   <None Include="$(BuildToolsDirectory)Icon.png" Pack="true" PackagePath="\" />

That should fix the issue. Ping me if any build code that was updated by me causing any problems. You can check git blame to see who wrote what line.

[michael-hawker]

Thanks for the tips @Nirmal4G. I remember we were trying to use PackageIconUrl still for some reason, but I don't remember what that reason was now... Maybe it was some prior VS issue that maybe's now resolved.

@niels9001 where else were we talking about the icon? I see we have #77 as well, but I don't see our prior chat there.

Let's get the new icon setup next week during a 1:1 and then we can get a PR opened to close this and that issue together.

[niels9001]

For reference, NuGet icon for Labs can be found here: https://github.com/CommunityToolkit/design-assets/blob/main/Logos/Windows-Labs/Windows-Labs.nuget-256.png