Skip to content

Conversation

@michael-hawker
Copy link
Member

Contributes to CommunityToolkit/Labs-Windows#133

Breaking Changes for Dependent Repos to update:

  • Remove <Version> from component source projects
  • Remove AdditionalAssemblyInfo.cs file from component source projects
  • Add MajorVersion, MinorVersion, and optionally PreviewVersion to root properties

These are now automatically handled by the assembly metadata generation added to ToolkitComponent.SourceProject.props

This PR does the following:

  • Inline version definitions of NuGet packages in other prop files (makes it more streamlined, but also makes it easier to find/replace <Version> in repo for components)
  • Automatically sets component package versions based on a root defined MajorVersion and MinorVersion property with optional PreviewVersion tag suffix property as well (to be defined in consuming repo) creates a version in format of Major.Minor.yyMMdd[-Preview]
  • Sets InternalsVisibleTo within the new assembly metadata generation instead of needing an independent file

…ceProject.props file

Uses MajorVersion.MinorVersion.yyMMdd[-PreviewVersion] format
…sion>

Remove <Version> from project template
…Component.SourceProject.props file

(with the rest of the assembly generation work)
@michael-hawker
Copy link
Member Author

Once this is working as part of CommunityToolkit/Windows#162 - we should merge that one first to generate new packages so we can update the package references for extensions and things here in the tooling. Then we can make all the updates and test in Labs-Windows as well.

@michael-hawker
Copy link
Member Author

Ah, need to update the tooling/.github/workflows/config directory props file with the new properties...

@michael-hawker
Copy link
Member Author

Our MainLatest feed has the new packages now:

image

🎉

Going to update the references to the packages for the Extensions and Converters here, then we can get this PR in.

@michael-hawker michael-hawker marked this pull request as ready for review August 1, 2023 17:49
@michael-hawker michael-hawker merged commit 02a05b9 into main Aug 1, 2023
@delete-merged-branch delete-merged-branch bot deleted the llama/auto-set-version branch August 1, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants