Skip to content

Another fix for the Converters ProjectReference logic #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michael-hawker merged 1 commit into from
Aug 3, 2023
Merged

Another fix for the Converters ProjectReference logic #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions ProjectHeads/App.Head.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,16 @@
<PackageReference Include="CommunityToolkit.$(DependencyVariant).Converters" Version="8.0.230801-preview"/>
</ItemGroup>
</When>
<Otherwise>
<!-- This is tripping up the linux build using dotnet build as we have a duplicate reference
auto-generated in tooling/MultiTarget/Generated when building the all-up sample app -->
<!-- See: https://github.com/dotnet/msbuild/issues/2688 -->
<!-- TODO: We need to handle a case where a component itself references the converter package... -->
<!-- Only add Converters reference if we're in a single experiment that's not the Converters project itself -->
<When Condition="'$(IsSingleExperimentHead)' == 'true' and $(MSBuildProjectName.StartsWith('Converters')) == 'false'">
<ItemGroup>
<!-- This is tripping up the linux build using dotnet build as we have a duplicate reference auto-generated in tooling/MultiTarget/Generated -->
<!-- See: https://github.com/dotnet/msbuild/issues/2688 -->
<!--<ProjectReference Include="$(ToolkitConvertersSourceProject)"/>-->
<ProjectReference Include="$(ToolkitConvertersSourceProject)"/>
</ItemGroup>
</Otherwise>
</When>
</Choose>

<!-- See https://github.com/CommunityToolkit/Labs-Windows/issues/142 -->
Expand Down