Fixed generated option pane attributes being incorrectly pruned #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@Arlodotexe I know your new test didn't repro it (confusingly), but did we want to include it anyway for other possible issues in the future? |
michael-hawker
approved these changes
Mar 23, 2023
michael-hawker
added
dev loop ➰
Member
Author
The test I had drafted didn't do anything new or different. It was a copy-paste of an existing test (but with the SettingsExpander sample/attributes) that I used for initial debugging. I couldn't repro the issue with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a small change that closes #20.