-
Notifications
You must be signed in to change notification settings - Fork 18
Feature: Generated button for sample option pane #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Generated button for sample option pane #44
Conversation
…for when executing in tests
|
@michael-hawker Looks like C# 11 isn't supported by the .NET 6 SDK? We need this for string literals |
Yeah .NET 6 = C#10, .NET 7 = C#11, so we'd need to bump the version in the |
|
This PR is experiencing a major blocker related to the source generator. The generated button option has been removed and the remaining changes and improvements have been moved to #69. As a substitute, we'll use a custom options pane that can hold any sample options we need. |
Summary
This PR contains all necessary changes to close #4, and some additional quality of life changes.
Refactored SampleGen source generator
ToolkitSampleButtonActionAttributeand all the necessary plumbing to use it (see below)Refactored SampleGen test tooling
Until recently, tests only checked the diagnostic output of a source generator, not the actual generated code. This changed with CommunityToolkit/Labs-Windows#336 when we added the
PaneOption_GeneratesTitlePropertytest.WIP: Pending issues
This PR is still work in progress. There may still be some functional bugs and missing plumbing: