Skip to content

Suppress warnings for IDisposable exposed by Uno #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Arlodotexe merged 3 commits into from
May 27, 2023
Merged

Suppress warnings for IDisposable exposed by Uno #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c67cdd
Suppressed CA1063
Arlodotexe May 26, 2023
d083841
Suppress CA1001
Arlodotexe May 26, 2023
e64ac0e
Force pagefile to 32GB for new-experiment CI job
Arlodotexe May 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,13 @@ jobs:
TEST_PROJECT_DIRECTORY: components/CiTestExp

steps:
- name: Configure Pagefile
uses: al-cheb/configure-pagefile-action@v1.2
with:
minimum-size: 32GB
maximum-size: 32GB
disk-root: "C:"

- name: Install .NET SDK v${{ env.DOTNET_VERSION }}
uses: actions/setup-dotnet@v3
with:
Expand Down
11 changes: 10 additions & 1 deletion MultiTarget/Uno.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
<ItemGroup Condition="'$(IsUno)' == 'true'">
<PackageReference Include="Uno.UI" Version="4.6.18" />
</ItemGroup>

<PropertyGroup Condition="'$(IsUno)' == 'true'">
<UnoUIUseRoslynSourceGenerators>true</UnoUIUseRoslynSourceGenerators>
</PropertyGroup>
Expand All @@ -20,11 +20,20 @@
<ItemGroup Condition="'$(IsWpfHead)' == 'true'">
<PackageReference Include="Uno.UI.Skia.Wpf" Version="4.6.18" />
</ItemGroup>

<PropertyGroup Condition="'$(IsWpfHead)' == 'true'">
<!-- Ignorable issue from SkiaSharp package, see: https://github.com/CommunityToolkit/Labs-Windows/pull/119#issuecomment-1125373091 -->
<NoWarn>$(NoWarn);NU1701</NoWarn>
</PropertyGroup>

<PropertyGroup>
<!--
Uno uses IDisposable internally, but exposes it publicly.
See https://github.com/CommunityToolkit/Labs-Windows/pull/275#issuecomment-1331113635
-->
<NoWarn>$(NoWarn);CA1063;CA1001;</NoWarn>
</PropertyGroup>

<ItemGroup Condition="'$(IsWasmHead)' == 'true'">
<PackageReference Include="Uno.UI.WebAssembly" Version="4.6.18" />
</ItemGroup>
Expand Down