Skip to content

Release mode hotfix for SampleGen #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Arlodotexe merged 3 commits into from
Jul 7, 2023
Merged

Release mode hotfix for SampleGen #93

Arlodotexe merged 3 commits into from
Jul 7, 2023

Conversation

@Arlodotexe
Copy link
Member

@Arlodotexe Arlodotexe commented Jul 6, 2023

This PR contains hotfixes that our CI didn't catch in #69. These errors instead manifested in CI for CommunityToolkit/Windows#113.

@Arlodotexe Arlodotexe self-assigned this Jul 6, 2023
@Arlodotexe Arlodotexe requested a review from michael-hawker July 6, 2023 20:15
@Arlodotexe Arlodotexe added build 🔥 regression What was working is now broke dev loop ➰ For issues that impact the core dev-loop of building experiments labels Jul 6, 2023
michael-hawker
michael-hawker approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@michael-hawker michael-hawker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do anything to the CI here to help catch these in the future?

@Arlodotexe
Copy link
Member Author

Arlodotexe commented Jul 7, 2023

Can we do anything to the CI here to help catch these in the future?

This test was being run as part of the tests in the All components solution, but since the tooling doesn't hold any components we aren't running those tests. I think we need to add a new job to run tooling tests to the build.yml.

@Arlodotexe
Copy link
Member Author

Arlodotexe commented Jul 7, 2023

Ah, found it! We were running CI tests in Debug mode, where the other repo was in Release mode. WarningsAsErrors wasn't enabled because of this. Should be fixed now.

@Arlodotexe Arlodotexe merged commit 38728ba into main Jul 7, 2023
@delete-merged-branch delete-merged-branch bot deleted the hotfix/samplegen branch July 7, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michael-hawker michael-hawker michael-hawker approved these changes

Assignees

@Arlodotexe Arlodotexe

Labels

build 🔥 dev loop ➰ For issues that impact the core dev-loop of building experiments regression What was working is now broke

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Arlodotexe @michael-hawker