HeaderedControls #109
Merged
HeaderedControls #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
michael-hawker
left a comment
michael-hawker
left a comment
There was a problem hiding this comment.
Awesome, thanks for bringing these over! Agree we should just have a single package for all these 'light-weight' helpers. Wonder if we're missing any at this point... 😋
Couple of small comments.
components/HeaderedControls/src/HeaderedContentControl/HeaderedContentControl.xaml
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
@michael-hawker I think I addressed your feedback :-). Added the same tests that are normally generated by default. |
michael-hawker
requested changes
Jul 7, 2023
Member
michael-hawker
left a comment
michael-hawker
left a comment
There was a problem hiding this comment.
Couple minor fixes needed, otherwise looks good. I'll push a fix for the WUX/MUXC issue though quick as I tested locally.
components/HeaderedControls/samples/HeaderedTreeViewSample.xaml
Outdated
Show resolved
Hide resolved
Caused unhelpful exception when running in UWP
michael-hawker
approved these changes
Jul 10, 2023
Arlodotexe
requested changes
Jul 10, 2023
components/HeaderedControls/src/CommunityToolkit.WinUI.Controls.HeaderedControls.csproj
Show resolved
Hide resolved
Arlodotexe
approved these changes
Jul 10, 2023
Member
|
Thanks @Arlodotexe for fixing that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HeaderedControlscomponent that includes theHeaderedContentControl,HeaderedItemsControlandHeaderedTreeView.HeaderedItemsControlfrom: [Experiment] 🧪 DataTable Initial Prototype Labs-Windows#418HeaderedTreeViewfrom: [Experiment] 🧪 DataTable Initial Prototype Labs-Windows#418HeaderedTreeViewHeaderedContentControlandHeaderedItemsControl