Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 9 additions & 11 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ jobs:

- name: Run experiment tests against ${{ env.TEST_PLATFORM }}
id: test-platform
run: vstest.console.exe ./tooling/**/CommunityToolkit.Tests.${{ env.TEST_PLATFORM }}.build.appxrecipe /Framework:FrameworkUap10 /logger:"trx;LogFileName=${{ env.TEST_PLATFORM }}.trx"
run: vstest.console.exe ./tooling/**/CommunityToolkit.Tests.${{ env.TEST_PLATFORM }}.build.appxrecipe /Framework:FrameworkUap10 /logger:"trx;LogFileName=${{ env.TEST_PLATFORM }}.trx" /Blame

- name: Create test reports
run: |
Expand All @@ -182,26 +182,24 @@ jobs:

# https://github.com/dorny/paths-filter#custom-processing-of-changed-files
- name: Detect If any Dump Files
uses: dorny/paths-filter@v2.11.1
id: filter
with:
list-files: shell
filters: |
dump:
- added: '${{ github.workspace }}/CrashDumps/*.dmp'
id: detect-dump
if: always()
working-directory: ${{ github.workspace }}
run: |
echo "DUMP_FILE=$(Get-ChildItem .\CrashDumps\*.dmp -ErrorAction SilentlyContinue)" >> $env:GITHUB_OUTPUT

- name: Artifact - WER crash dumps
uses: actions/upload-artifact@v3
if: ${{ steps.filter.outputs.dump == 'true' && (env.ENABLE_DIAGNOSTICS == 'true' || env.COREHOST_TRACE != '') && always() }}
if: ${{ (env.ENABLE_DIAGNOSTICS == 'true' || env.COREHOST_TRACE != '') && always() }}
with:
name: CrashDumps-${{ matrix.platform }}
path: '${{ github.workspace }}/CrashDumps'

- name: Analyze Dump
if: ${{ steps.filter.outputs.dump == 'true' && (env.ENABLE_DIAGNOSTICS == 'true' || env.COREHOST_TRACE != '') && always() }}
if: ${{ steps.detect-dump.outputs.DUMP_FILE != '' && (env.ENABLE_DIAGNOSTICS == 'true' || env.COREHOST_TRACE != '') && always() }}
run: |
dotnet tool install --global dotnet-dump
dotnet-dump analyze ${{ steps.filter.outputs.dump_files }} -c "clrstack" -c "pe -lines" -c "exit"
dotnet-dump analyze ${{ steps.detect-dump.outputs.DUMP_FILE }} -c "clrstack" -c "pe -lines" -c "exit"

wasm-linux:
runs-on: ubuntu-latest
Expand Down
8 changes: 4 additions & 4 deletions Directory.Build.targets
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
<Project>

<ItemGroup Condition="'$(Configuration)' == 'Release'">
<PackageReference Include="NuGet.Build.Tasks.Pack" Version="5.2.0" PrivateAssets="all" Pack="false" />
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0" PrivateAssets="All" />
<PackageReference Include="NuGet.Build.Tasks.Pack" Version="6.7.0" PrivateAssets="all" Pack="false" />
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.1.1" PrivateAssets="All" />
</ItemGroup>

<PropertyGroup>
<CommonTags>$(CommonTags);UWP;WinUI;Uno;Labs;Experimental</CommonTags>
<CommonTags>$(CommonTags);UWP;WinUI;Uno;Platform;WindowsAppSDK;WASDK;WinAppSDK;Universal</CommonTags>
<PackageTags Condition="'$(PackageTags)' != ''">$(CommonTags);$(PackageTags)</PackageTags>
<PackageTags Condition="'$(PackageTags)' == ''">$(CommonTags)</PackageTags>
</PropertyGroup>

<ItemGroup Condition="$(IsPackable)">
<None Include="$(RepositoryDirectory)Icon.png" Pack="true" PackagePath="\" />
<None Include="$(RepositoryDirectory)icon.png" Pack="true" PackagePath="\" />
<None Include="$(RepositoryDirectory)License.md" Pack="true" PackagePath="\" />
<!--<None Include="$(RepositoryDirectory)ThirdPartyNotices.txt" Pack="true" PackagePath="\" />-->
</ItemGroup>
Expand Down
3 changes: 2 additions & 1 deletion Windows.Toolkit.Common.props
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@
<Copyright>(c) .NET Foundation and Contributors. All rights reserved.</Copyright>
<PackageProjectUrl>https://github.com/CommunityToolkit/Windows</PackageProjectUrl>
<PackageReleaseNotes>https://github.com/CommunityToolkit/Windows/releases</PackageReleaseNotes>
<PackageIcon>Icon.png</PackageIcon>
<PackageIcon>icon.png</PackageIcon>
<PackageIconUrl>https://github.com/CommunityToolkit/Windows/blob/main/icon.png</PackageIconUrl>
<!-- TODO: Remove when closing https://github.com/CommunityToolkit/Labs-Windows/issues/256 -->
<NoWarn>$(NoWarn);NU1505;NU1504</NoWarn>
</PropertyGroup>
Expand Down
3 changes: 2 additions & 1 deletion components/Extensions/tests/DispatcherQueueExtensionTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -336,8 +336,9 @@ await DispatcherQueue.GetForCurrentThread().EnqueueAsync(async () =>
Assert.IsNull(taskSource.Task.Exception);
}

[Ignore]
[TestCategory("DispatcherQueueExtensions")]
[UIThreadTestMethod]
////[UIThreadTestMethod] - TODO: https://github.com/CommunityToolkit/Tooling-Windows-Submodule/issues/121
public async Task DispatcherQueueHelper_FuncOfTaskOfT_Exception()
{
var task = DispatcherQueue.GetForCurrentThread().EnqueueAsync(new Func<Task<int>>(() =>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,9 @@ public async Task FrameworkElementExtension_RelativeAncestor_FreeParentBaseline(
Assert.IsFalse(textRef.IsAlive, "TextBox is still alive...");
}

[Ignore]
[TestCategory("FrameworkElementExtension")]
[UIThreadTestMethod]
////[UIThreadTestMethod] - TODO: https://github.com/CommunityToolkit/Tooling-Windows-Submodule/issues/121
public async Task FrameworkElementExtension_RelativeAncestor_FreeParent(FrameworkElementRelativeAncestorDataTemplateTestPage page)
{
var list = page.FindDescendant<ListView>();
Expand All @@ -85,9 +86,9 @@ public async Task FrameworkElementExtension_RelativeAncestor_FreeParent(Framewor
Assert.IsFalse(listRef.IsAlive, "ListView is still alive...");
}

[TestCategory("FrameworkElementExtension")]
[UIThreadTestMethod]
[Ignore]
[TestCategory("FrameworkElementExtension")]
////[UIThreadTestMethod] - TODO: https://github.com/CommunityToolkit/Tooling-Windows-Submodule/issues/121
public async Task FrameworkElementExtension_RelativeAncestor_FreePageNavigation()
{
TaskCompletionSource<bool?> taskCompletionSource = new();
Expand Down
File renamed without changes