ImageEx IsCacheEnabled property not working.

[aodpi]

I'm submitting a...

Bug report (I searched for similar issues and did not find one)

Current behavior

At the moment the property IsCacheEnabled from ImageEx control doesn't seem to work. Setting it to false displays a cached image even though the physical image has changed.

I think that the code at this line:
https://github.com/Microsoft/WindowsCommunityToolkit/blob/6baca53664113e5518c76a3196710b3b0647717f/Microsoft.Toolkit.Uwp.UI.Controls/ImageEx/ImageExBase.Source.cs#L177

should have the BitmapImage.CreateOptions property set to IgnoreImageCache so that indeed it does not cache the image internally by UWP.

I have tested this behavior by creating a simple UWP Image control with a BitmapImage as a source and setting the CreateOptions to IgnoreImageCache and it works as expected.

Expected behavior

Setting ImageEx.IsCacheEnabled to false would always request a fresh image.

Minimal reproduction of the problem with instructions

Environment

Nuget Package(s): 
Microsoft.Toolkit.Uwp.UI.Controls
Package Version(s): 
4.0.0

Windows 10 Build Number:
- [x] Creators Update (15063)
- [ ] Fall Creators Update (16299)
- [ ] April 2018 Update (17134)
- [ ] Insider Build (build number: )

App min and target version:
- [ ] Creators Update (15063)
- [x] Fall Creators Update (16299)
- [ ] April 2018 Update (17134)
- [ ] Insider Build (xxxxx)

Device form factor:
- [x] Desktop
- [ ] Mobile
- [ ] Xbox
- [ ] Surface Hub
- [ ] IoT

Visual Studio 
- [x] 2017 (version: 15.8.3)
- [ ] 2017 Preview (version: )

[azchohfi]

@WilliamABradley could you take a look at this? Is this broken? What is the expected behavior?

[WilliamABradley]

@azchohfi Sorry, I have no idea, I only separated ImageExBase from ImageEx for the RoundImageEx.

[aodpi]

Thank you for feedback, i'll try to implement a solution to this with a PR soon.

[nmetulev]

Please do @aodpi. Including @hermitdave for review as well

[svidouse]

Got a same issue...

IsCacheEnabled="True"
But when in flight mode, pictures do not load from cache (or some).
I tried this way :

Run app with network connectivity, imageex is loading picture from the web
Run then the app without network : gray rectangles instead of cached pictures (but some are working)

[aodpi]

@svidouse Could it be that those images that don't load didn't succeed to cache,?

[svidouse]

I think so Cordialement, Stéphane Vidouse Cassio SPRL Le 21 sept. 2018 à 21:27, Valeriu Balan <notifications@github.com<mailto:notifications@github.com>> a écrit : @svidouse<https://github.com/svidouse> Could it be that those images that don't load didn't succeed to cache,? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#2460 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/Apda80KD92CsfT9p-G1rQoOeqz3KlB3vks5udT22gaJpZM4WjOf6>.

[nmetulev]

Merged