-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Closed
Labels
Completed 🔥bug 🐛An unexpected issue that highlights incorrect behaviorAn unexpected issue that highlights incorrect behaviorbuild 🔥external ⤴️Requires an update to an external dependency or due to code outside the Toolkit.Requires an update to an external dependency or due to code outside the Toolkit.visual studio 🔀
Milestone
Description
Describe the bug
After updating VS2019 to 16.8, the Windows Community Toolkit solution is no longer building.
The build is failing at the nuget restoration step with:
1>------ Rebuild All started: Project: Microsoft.Toolkit, Configuration: Debug Any CPU ------
Error occurred while restoring NuGet packages: Invalid restore input. Duplicate frameworks found: 'netstandard1.4, uap10.0.17763, uap10.0.17763, net461, netcoreapp3.1'. Input files: C:\[...]\WindowsCommunityToolkit\Microsoft.Toolkit.Uwp.Notifications\Microsoft.Toolkit.Uwp.Notifications.csproj.
1>Microsoft.Toolkit -> C:\[...]\WindowsCommunityToolkit\Microsoft.Toolkit\bin\Debug\netstandard2.1\Microsoft.Toolkit.dll
1>Microsoft.Toolkit -> C:\[...]\WindowsCommunityToolkit\Microsoft.Toolkit\bin\Debug\netstandard1.4\Microsoft.Toolkit.dll
1>Microsoft.Toolkit -> C:\[...]\WindowsCommunityToolkit\Microsoft.Toolkit\bin\Debug\netstandard2.0\Microsoft.Toolkit.dll
========== Rebuild All: 1 succeeded, 0 failed, 0 skipped ==========
- Is this bug a regression in the toolkit? If so, what toolkit version did you last see it work:
Steps to Reproduce
- Can this be reproduced in the Sample App? (Either in a sample as-is or with new XAML pasted in the editor.) If so, please provide custom XAML or steps to reproduce. If not, let us know why it can't be reproduced (e.g. more complex setup, environment, dependencies, etc...)
Steps to reproduce the behavior:
- Update VS2019 to 18.8.1
- Open the solution
- Build or rebuild solution
Expected behavior
The solution builds.
Environment
NuGet Package(s):
Package Version(s):
Windows 10 Build Number:
- [ ] Fall Creators Update (16299)
- [ ] April 2018 Update (17134)
- [ ] October 2018 Update (17763)
- [ ] May 2019 Update (18362)
- [X] May 2020 Update (19041)
- [ ] Insider Build (build number: )
Visual Studio
- [ ] 2017 (version: )
- [X] 2019 (version: 16.8.1)
- [ ] 2019 Preview (version: )
Additional context
The problem seems to be related to the Microsoft.Toolkit.Uwp.Notifications.csproj
Removing the native target from the TargetFrameworks list of the project fix the nuget restore operation but then the build is failing later with symbols not being found.
I changed
<TargetFrameworks>netstandard1.4;uap10.0;native;net461;netcoreapp3.1</TargetFrameworks>
to
<TargetFrameworks>netstandard1.4;uap10.0;net461;netcoreapp3.1</TargetFrameworks>
thom0707 and baskren
Metadata
Metadata
Assignees
Labels
Completed 🔥bug 🐛An unexpected issue that highlights incorrect behaviorAn unexpected issue that highlights incorrect behaviorbuild 🔥external ⤴️Requires an update to an external dependency or due to code outside the Toolkit.Requires an update to an external dependency or due to code outside the Toolkit.visual studio 🔀