Graph Control Prep #3033
Merged
Graph Control Prep #3033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lkit.Uwp.UI FileSize String Extension and Converter Centralize Usage in other places from OneDrive and SharePoint
9 tasks
michael-hawker
commented
Oct 23, 2019
azchohfi
requested changes
Oct 24, 2019
Member
Author
|
Forgot header for new file, fixing... |
Member
Author
|
@azchohfi think we're all set now? |
skendrot
reviewed
Oct 25, 2019
azchohfi
approved these changes
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helpers needed for Graph Controls
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Duplication of needed string formatting for file sizes.
What is the new behavior?
Centralized to helper in Microsoft.Toolkit.
Moved Converter to rest of Converters.
Deprecated Graph controls that will be replaced in the future by the new ones.
PR Checklist
Please check if your PR fulfills the following requirements:
Other information