Updated StyleCop to 1.1.118. #3189
Merged
+164
−172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks azchohfi for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
assigned
7 tasks
azchohfi
commented
Mar 25, 2020
| using Windows.UI.Xaml; | ||
| using Windows.UI.Xaml.Controls; | ||
|
|
||
| [assembly: InternalsVisibleTo("UnitTests")] |
Contributor
Author
There was a problem hiding this comment.
Just to help reviewing, this was removed because it is a duplicate (https://github.com/windows-toolkit/WindowsCommunityToolkit/blob/master/Microsoft.Toolkit.Uwp.UI.Controls/Properties/AssemblyInfo.cs#L11)
Member
michael-hawker
left a comment
michael-hawker
left a comment
There was a problem hiding this comment.
Couple of questions. Otherwise looks great.
Microsoft.Toolkit.Uwp.UI.Controls.DataGrid/CollectionViews/ListCollectionView.cs
Show resolved
Hide resolved
...soft.Toolkit.Uwp.UI.Controls.DataGrid/DataGrid/Automation/DataGridGroupItemAutomationPeer.cs
Show resolved
Hide resolved
Member
|
Thanks @azchohfi! 🎉 |
36 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3187
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Old version of StyleCop.
What is the new behavior?
Latest stable version of StyleCop, and some minor code adjustments to fit the new rules.
PR Checklist
Please check if your PR fulfills the following requirements: