Refactoring/Improvements based on Community Feedback to Pipeline Brushes #3304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes from official master
Changes from master
Changes from master
|
Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
assigned
Member
michael-hawker
left a comment
michael-hawker
left a comment
There was a problem hiding this comment.
Couple of quick questions, otherwise looks pretty good.
michael-hawker
changed the title
Member
|
@Sergio0694 should we update the brushes with the Clamp as well? I just tried to mess with the AcrylicBrush values... 😋 Otherwise looks good! |
Member
Author
|
@michael-hawker Fixed both that and the blur property in d7ce515 and 762e510 🚀 |
michael-hawker
approved these changes
May 28, 2020
azchohfi
requested changes
May 29, 2020
|
This PR has been marked as "needs attention 👋" and awaiting a response from the team. |
Co-authored-by: Alexandre Zollinger Chohfi <chohfi@outlook.com>
…rgio0694/WindowsCommunityToolkit into refactoring/more-win2d-tweaks
azchohfi
approved these changes
May 29, 2020
Kyaa-dost
approved these changes
May 29, 2020
Contributor
Kyaa-dost
left a comment
Kyaa-dost
left a comment
There was a problem hiding this comment.
@Sergio0694 Looking great ✅✅
Member
Author
|
@Kyaa-dost Awesome, thank you for the review! Glad you like the new APIs! 🚀 |
This was referenced May 30, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #3112 and #3298
PR Type
What kind of change does this PR introduce?
What is the new behavior?
BlendEffect.Placementproperty was counterintuitive, and has been inverted.CrossFadeEffectnodeplacementparameter fromCrossFademethodsPR Checklist
Please check if your PR fulfills the following requirements: