Updates to TokenizingTextBox Style to be consistent whether or not WinUI is included #3314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to understand how to default icon size to the proper size in style, not sure if possible, may need to copy somehow instead?
|
Thanks michael-hawker for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
assigned
michael-hawker
commented
May 29, 2020
Microsoft.Toolkit.Uwp.SampleApp/SamplePages/TokenizingTextBox/TokenizingTextBoxXaml.bind
Show resolved
Hide resolved
Sergio0694
reviewed
May 29, 2020
Microsoft.Toolkit.Uwp.UI.Controls/TokenizingTextBox/TokenizingTextBox.xaml
Outdated
Show resolved
Hide resolved
Sergio0694
reviewed
May 29, 2020
Microsoft.Toolkit.Uwp.UI.Controls/TokenizingTextBox/TokenizingTextBox.xaml
Outdated
Show resolved
Hide resolved
…TextBox.xaml Co-authored-by: Sergio Pedri <sergio0694@live.com>
azchohfi
approved these changes
Jun 1, 2020
Contributor
azchohfi
left a comment
azchohfi
left a comment
There was a problem hiding this comment.
I'm ok with this change. its not idea, but its what we can do for now.
marcpems
approved these changes
Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #3310
We had an issue where including WinUI would change our default styling of the TTB. This addresses those concerns.
In draft, as still a remaining discussion around the use of IconSource here, related to WinUI issue filed here: microsoft/microsoft-ui-xaml#2568
PR Type
What kind of change does this PR introduce?
What is the current behavior?
WinUI increases height of inner textbox causing odd padding below tokens.
What is the new behavior?
No longer an issue
PR Checklist
Please check if your PR fulfills the following requirements:
Other information